Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-codepipeline] ActionDeclaration - Support BatchEnabled configuration #11662

Closed
1 of 2 tasks
tjenkinson opened this issue Nov 24, 2020 · 2 comments · Fixed by #11741
Closed
1 of 2 tasks

[aws-codepipeline] ActionDeclaration - Support BatchEnabled configuration #11662

tjenkinson opened this issue Nov 24, 2020 · 2 comments · Fixed by #11741
Assignees
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p1

Comments

@tjenkinson
Copy link
Contributor

See this doc which says

To enable batch builds in CodePipeline, set the BatchEnabled parameter of the configuration object to true.

The configuration object it is referring to is this.

It is not possible right now to provide this on the CodeBuildAction

Use Case

We need to add a batch code build action to our pipeline.

Proposed Solution

    const codebuildAction = new codepipelineActions.CodeBuildAction({
      actionName: 'Build',
      project: createCodeBuildProject(),
      input,
      batchEnabled: true // something like this
    })

would set the BatchEnabled property on Configuration to true.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@skinny85
Copy link
Contributor

Thanks for opening the issue @tjenkinson . Any chance of opening us a PR adding this? 🙂 Here's our Contributing guide: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md

Thanks,
Adam

@skinny85 skinny85 added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p1 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 24, 2020
@mergify mergify bot closed this as completed in #11741 Dec 3, 2020
mergify bot pushed a commit that referenced this issue Dec 3, 2020
…Action` (#11741)

See [this doc](https://docs.aws.amazon.com/codebuild/latest/userguide/sample-pipeline-batch.html) which says

>To enable batch builds in CodePipeline, set the BatchEnabled parameter of the configuration object to true.

The configuration object it is referring to is [this](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-stages-actions.html#cfn-codepipeline-pipeline-stages-actions-configuration).

I didn't add a test to ensure that `BatchEnabled` is not present by default because I wasn't sure exactly how to do this. Let me know if this is needed. It looks like `haveResourceLike` can take a function on `properties`, so maybe it's doable with that?

Closes #11662
@github-actions
Copy link

github-actions bot commented Dec 3, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants