Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-codebuild] support webhook ''BUILD_BATCH" BuildType #11663

Closed
1 of 2 tasks
tjenkinson opened this issue Nov 24, 2020 · 4 comments · Fixed by #11743
Closed
1 of 2 tasks

[aws-codebuild] support webhook ''BUILD_BATCH" BuildType #11663

tjenkinson opened this issue Nov 24, 2020 · 4 comments · Fixed by #11743
Assignees
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@tjenkinson
Copy link
Contributor

We'd like to set the webhook trigger to trigger a batch build, instead of a standard one.

Use Case

We want to trigger the batch build from a webhook.

Proposed Solution

const gitHubSource = codebuild.Source.gitHub({
  owner: 'awslabs',
  repo: 'aws-cdk',
  webhook: 'BUILD_BATCH', // <---- also support a string/enum
  webhookFilters: [
    codebuild.FilterGroup
      .inEventOf(codebuild.EventAction.PUSH)
      .andBranchIs('master')
      .andCommitMessageIs('the commit message'),
  ], // optional, by default all pushes and Pull Requests will trigger a build
});

Other

The BuildType is not documented yet, but it is mentioned as being supported in this comment: aws-cloudformation/cloudformation-coverage-roadmap#621 (comment)

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@tjenkinson tjenkinson added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 24, 2020
@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Nov 24, 2020
@skinny85
Copy link
Contributor

Hey @tjenkinson ,

thanks for opening the issue. Unfortunately, we can't change the type of the webhook property, but we can add a new property, something like startBatchBuild?: boolean.

@skinny85 skinny85 added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 24, 2020
@tjenkinson
Copy link
Contributor Author

That would be great 👍

@tjenkinson
Copy link
Contributor Author

I think I’ve found the starting point for this change so I’ll prepare a pr :)

@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Dec 7, 2020
@mergify mergify bot closed this as completed in #11743 Dec 24, 2020
mergify bot pushed a commit that referenced this issue Dec 24, 2020
This adds a `startBatchBuild` option to the code build source, to trigger a batch build. The cloudformation property isn't in the official docs yet but is mentioned [here](aws-cloudformation/cloudformation-coverage-roadmap#621 (comment)).

Closes #11663
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
This adds a `startBatchBuild` option to the code build source, to trigger a batch build. The cloudformation property isn't in the official docs yet but is mentioned [here](aws-cloudformation/cloudformation-coverage-roadmap#621 (comment)).

Closes aws#11663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants