Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-eks): Add validate flag to KubernetesManifest class to pass invalidated objects #11763

Closed
shrivastavshubham34 opened this issue Nov 29, 2020 · 5 comments · Fixed by #12012
Assignees
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@shrivastavshubham34
Copy link

shrivastavshubham34 commented Nov 29, 2020

It would be great if we could pass unvalidated resources.
Since the flag --validate=false was added to kubectl. We could probably have a constructor attribute called validate.

Use Case

I'm trying to add an ALB ingress controller to the EKS cluster. But right now cannot do that through CDK.
I need to add cert-manager which needs to be run without validation.
Source:EKS-ALB-Ingress-Guide

kubectl apply --validate=false -f https://github.com/jetstack/cert-manager/releases/download/v1.0.2/cert-manager.yaml

Proposed Solution

Add constructor props to KubernetesManifest class to include --validate as an boolean argument.
Also add a validate prop to addManifest() function of @aws-cdk/aws-eks.Cluster class

        cluster.add_manifest('alb-ingress-controller-core',*manifest,validate=false)


This is a 🚀 Feature Request

@shrivastavshubham34 shrivastavshubham34 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 29, 2020
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Nov 29, 2020
@iliapolo iliapolo added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Nov 29, 2020
@shrivastavshubham34
Copy link
Author

Hi, do we have an ETA for this? If not I can switch to EKSCTL for the time being, 😄

@mergify mergify bot closed this as completed in #12012 Dec 22, 2020
mergify bot pushed a commit that referenced this issue Dec 22, 2020
Closes #11763

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@andremcdecarvalho
Copy link

andremcdecarvalho commented Dec 23, 2020

Hello everyone,

When will this feature be available? I'm developing a US and I'm facing this exact problem.

Thanks in advance!

@iliapolo
Copy link
Contributor

This will be available in the next release.

@shrivastavshubham34
Copy link
Author

Thanks @iliapolo !

flochaz pushed a commit to flochaz/aws-cdk that referenced this issue Jan 5, 2021
Closes aws#11763

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants