Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(init-templates/python): incorrect venv directory ignored in .gitignore #12229

Closed
idanlupinsky opened this issue Dec 26, 2020 · 1 comment · Fixed by #12429
Closed

(init-templates/python): incorrect venv directory ignored in .gitignore #12229

idanlupinsky opened this issue Dec 26, 2020 · 1 comment · Fixed by #12429
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@idanlupinsky
Copy link
Contributor

The Python app project is initialized with a .venv folder, but the .gitignore specifies .env.

Reproduction Steps

cdk init --language python

What did you expect to happen?

The .gitignore file should include a ".venv" entry.

What actually happened?

The .gitignore file contains a ".env" entry.

Environment

  • CDK CLI Version : 1.80.0 (build 31132ca)
  • Framework Version:
  • Node.js Version: v15.5.0
  • OS : Mac OS Big Sur
  • Language (Version): Python 3.9.1

Other

This is 🐛 Bug Report
@idanlupinsky idanlupinsky added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 26, 2020
@idanlupinsky idanlupinsky mentioned this issue Dec 26, 2020
Merged
This was referenced Jan 8, 2021
Closed
Merged
@mergify mergify bot closed this as completed in #12429 Jan 12, 2021
mergify bot pushed a commit that referenced this issue Jan 12, 2021
@codeasashu
chore: ignore venv for python template (#12429)
a0aad85 
Fixes #12229

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

mergify bot pushed a commit that referenced this issue Feb 25, 2021
@idanlupinsky
chore(init-templates/python): correct virtual environment typo (#12230)
146a97f 
----
This is a suggested fix for #12229, a small typo in the init templates for Python.

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
1 participant
@idanlupinsky