-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(cli): Support hotswap for Docker Image Lambda function #18302
Comments
Thanks for opening the issue @tmokmss! That is indeed a great use case for hotswapping that I totally missed! |
Hi @skinny85, I'm happy to implement this feature but please let me know if you're already working on it. Thanks! |
That is great to hear @tmokmss! Fair word of warning: this will probably be a more complex change than an average Construct Library PR. For reference, take a look at a few PRs that implemented hotswapping for various resources (here's the original Lambda one, here's StepFunctions State Machines, here's CodeBuild Projects). Let me know if you'd still be interested in giving this a shot, and if you are, we are happy to leave this one for you 🙂. Thanks, |
@skinny85 Thank you for the kind offer! I submitted a PR above. (btw it now also supports InlineCode hotswap for feature completeness 👍 .) Although I checked basic behavior in my local env, please teach me if I'm missing any consideration. I'll add unit tests later. |
That's awesome @tmokmss, thanks so much for doing that! I'll check out the PR today. |
|
Description
Support hotswap for DockerImageFunction code.
Use Case
Just like normal lambda functions, we can quickly update DockerImageFunction code.
Proposed Solution
tbw
Other information
No response
Acknowledge
The text was updated successfully, but these errors were encountered: