Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDS: gp3 support #23036

Closed
1 of 2 tasks
sander-su opened this issue Nov 22, 2022 · 2 comments · Fixed by #22864
Closed
1 of 2 tasks

RDS: gp3 support #23036

sander-su opened this issue Nov 22, 2022 · 2 comments · Fixed by #22864
Assignees
@corymhall
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@sander-su
Copy link

Describe the feature

GP3 is now available for RDS:
https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-rds-general-purpose-gp3-storage-volumes/

Use Case

GP3 is faster and cheaper

Proposed Solution

Add GP3 to the storage enums

https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-rds/lib/instance.ts#L260

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.51.1

Environment details (OS name and version, etc.)

Win 10
@sander-su sander-su added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 22, 2022
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Nov 22, 2022
@pahud
Copy link
Contributor

pahud commented Nov 22, 2022

Thank you for your PR. This is definitely a great feature!

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 22, 2022
This was referenced Nov 23, 2022
Closed
Merged
@mergify mergify bot closed this as completed in #22864 Nov 25, 2022
mergify bot pushed a commit that referenced this issue Nov 25, 2022
@jogold
feat(rds): General Purpose gp3 storage volumes for database instance (#…
82c3646 
…22864)

Add support for GP3 storage type. Closes #23036 

See https://aws.amazon.com/about-aws/whats-new/2022/11/amazon-rds-general-purpose-gp3-storage-volumes/


----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corymhall corymhall

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
3 participants
@pahud @sander-su @corymhall