Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sagemaker: Support container images from private Docker registries #23156

Open
1 of 2 tasks
petermeansrock opened this issue Nov 29, 2022 · 0 comments
Open
1 of 2 tasks
Labels
@aws-cdk/aws-sagemaker Related to AWS SageMaker effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3

Comments

@petermeansrock
Copy link
Contributor

petermeansrock commented Nov 29, 2022

Describe the feature

As described in the SageMaker Endpoint L2 construct RFC:

Private Docker Registries: The ImageConfig type was added to the existing ContainerDefinition CloudFormation structure in order for customers to specify that a VPC-connected Docker registry will act as the source of the container's image (as opposed to ECR which acts as the default platform repository). This new type also contains an optional RepositoryAuthConfig nested structure in order to specify the ARN of a Lambda function capable of serving repository credentials to SageMaker.

Please 👍 this issue to help with the prioritization of this feature.

Use Case

Some customers may prefer to host images within a private Docker registry (rather than the currently supported ECR).

Proposed Solution

As described in the SageMaker Endpoint L2 construct RFC:

In order to deliver this functionality in a backward-compatible way, inspiration can be taken from [ECS's ContainerImage.fromRegistry API][container-image-from-registry] (note though, ECS sources credentials from Secrets Manager rather than Lambda) in order to make the following additions to the SageMaker module:

  1. Add attributes to ContainerImageConfig to support the specification of a non-platform repository along with an optional Lambda function ARN.
  2. Implement a new, non-exported RegistryImage subclass of ContainerImage whose constructor takes an optional Lambda IFunction instance for generating a ContainerImageConfig instance with the appropriate Lambda function ARN for serving credentials.
  3. On ContainerImage, add a new static fromRegistry method which takes a props object consisting of an optional Lambda IFunction instance. This method acts as a simple static factory method for the non-exported RegistryImage class.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.54.0-alpha.0

Environment details (OS name and version, etc.)

macOS Ventura

@petermeansrock petermeansrock added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 29, 2022
@github-actions github-actions bot added the @aws-cdk/aws-sagemaker Related to AWS SageMaker label Nov 29, 2022
@peterwoodworth peterwoodworth added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 29, 2022
@madeline-k madeline-k removed their assignment Oct 30, 2023
@pahud pahud added p3 and removed p2 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-sagemaker Related to AWS SageMaker effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p3
Projects
None yet
Development

No branches or pull requests

4 participants