Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SageMaker Model Hosting L2 Constructs #431

Closed
11 tasks done
petermeansrock opened this issue Apr 28, 2022 · 2 comments
Closed
11 tasks done

SageMaker Model Hosting L2 Constructs #431

petermeansrock opened this issue Apr 28, 2022 · 2 comments
Labels
management/tracking status/api-approved API Bar Raiser signed-off the API of this RFC status/implementing RFC is being implemented

Comments

@petermeansrock
Copy link
Contributor

petermeansrock commented Apr 28, 2022 •
edited
Loading

Description

"Amazon SageMaker provides every developer and data scientist with the ability to build, train, and deploy machine learning models quickly. Amazon SageMaker is a fully-managed service that covers the entire machine learning workflow to label and prepare your data, choose an algorithm, train the model, tune and optimize it for deployment, make predictions, and take action. Your models get to production faster with much less effort and lower cost."

This RFC will specifically target the delivery of an L2 construct for a SageMaker Endpoint resource which represents a hosted endpoint for real-time inference. As an endpoint itself depends on other resources, this RFC will extend to the following SageMaker resources as well:

  • EndpointConfig
  • Model

Note: The additional authors listed below contributed to the design of CDK implementation PR 6107 (which has been newly re-created in PR 20113), but are not currently engaged on the drafting of this RFC.

Roles

Role User
Proposed by @petermeansrock
Author(s) @petermeansrock, @mattmcclean, @l2yao, @jetterdj, @foxpro24, @rangoju
API Bar Raiser @kaizencc
Stakeholders TBD

See RFC Process for details

Workflow

  • Tracking issue created (label: status/proposed)
  • API bar raiser assigned (ping us at #aws-cdk-rfcs if needed)
  • Kick off meeting
  • RFC pull request submitted (label: status/review)
  • Community reach out (via Slack and/or Twitter)
  • API signed-off (label api-approved applied to pull request)
  • Final comments period (label: status/final-comments-period)
  • Approved and merged (label: status/approved)
  • Execution plan submitted (label: status/planning)
  • Plan approved and merged (label: status/implementing)
  • Implementation complete (label: status/done)

Author is responsible to progress the RFC according to this checklist, and
apply the relevant labels to this issue so that the RFC table in README gets
updated.
This was referenced Apr 28, 2022
Closed
Merged
@kaizencc kaizencc mentioned this issue Jul 22, 2022
Closed
11 tasks
@kaizencc kaizencc added status/review Proposal pending review/revision and removed status/proposed Newly proposed RFC labels Aug 31, 2022
@kaizencc kaizencc added status/final-comment-period Pending final approval status/api-approved API Bar Raiser signed-off the API of this RFC and removed status/review Proposal pending review/revision labels Oct 6, 2022
petermeansrock added a commit to petermeansrock/aws-cdk that referenced this issue Oct 18, 2022
@petermeansrock @mmcclean-aws
@l2yao @jetterdj @foxpro24 @rangoju
feat(sagemaker): add Model L2 construct
5737194 
This is the first of three PRs to complete the implementation of RFC
431:
aws/aws-cdk-rfcs#431

fixes aws#2809

Co-authored-by: Matt McClean <mmcclean@amazon.com>
Co-authored-by: Long Yao <yl1984108@gmail.com>
Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com>
Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com>
Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>
@petermeansrock petermeansrock mentioned this issue Oct 18, 2022
Merged
4 tasks
mergify bot pushed a commit to aws/aws-cdk that referenced this issue Nov 9, 2022
@petermeansrock
feat(sagemaker): add Model L2 construct (#22549)
93915f1 
This is the first of three PRs to complete the implementation of RFC 431:
aws/aws-cdk-rfcs#431

fixes #2809

Co-authored-by: Matt McClean <mmcclean@amazon.com>
Co-authored-by: Long Yao <yl1984108@gmail.com>
Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com>
Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com>
Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>


----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
petermeansrock added a commit to petermeansrock/aws-cdk that referenced this issue Nov 10, 2022
@petermeansrock @mmcclean-aws
@l2yao @jetterdj @foxpro24 @rangoju
feat(sagemaker): add EndpointConfig L2 construct
8c8a4f9 
This is the second of three PRs to complete the implementation of RFC
431:
aws/aws-cdk-rfcs#431

related to aws#2809

Co-authored-by: Matt McClean <mmcclean@amazon.com>
Co-authored-by: Long Yao <yl1984108@gmail.com>
Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com>
Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com>
Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>
@petermeansrock petermeansrock mentioned this issue Nov 10, 2022
Merged
4 tasks
@kaizencc kaizencc added status/implementing RFC is being implemented and removed status/final-comment-period Pending final approval labels Nov 10, 2022
mergify bot pushed a commit to aws/aws-cdk that referenced this issue Nov 11, 2022
@petermeansrock @mmcclean-aws
@l2yao @jetterdj @foxpro24 @rangoju
feat(sagemaker): add EndpointConfig L2 construct (#22865)
0e97c15 
This is the second of three PRs to complete the implementation of RFC 431:
aws/aws-cdk-rfcs#431

related to #2809

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

----

Co-authored-by: Matt McClean <mmcclean@amazon.com>
Co-authored-by: Long Yao <yl1984108@gmail.com>
Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com>
Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com>
Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>
petermeansrock added a commit to petermeansrock/aws-cdk that referenced this issue Nov 11, 2022
@petermeansrock @mmcclean-aws
@l2yao @jetterdj @foxpro24 @rangoju
feat(sagemaker): add Endpoint L2 construct
a139468 
This is the third and final PR to complete the implementation of RFC
431:
aws/aws-cdk-rfcs#431

closes aws#2809

Co-authored-by: Matt McClean <mmcclean@amazon.com>
Co-authored-by: Long Yao <yl1984108@gmail.com>
Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com>
Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com>
Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>
@petermeansrock petermeansrock mentioned this issue Nov 11, 2022
Merged
4 tasks
mergify bot pushed a commit to aws/aws-cdk that referenced this issue Nov 25, 2022
@petermeansrock @mmcclean-aws
@l2yao @jetterdj @foxpro24 @rangoju
feat(sagemaker): add Endpoint L2 construct (#22886)
bf7586b 
This is the third and final PR to complete the implementation of RFC 431:
aws/aws-cdk-rfcs#431

closes #2809

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

----

Co-authored-by: Matt McClean <mmcclean@amazon.com>
Co-authored-by: Long Yao <yl1984108@gmail.com>
Co-authored-by: Drew Jetter <60628154+jetterdj@users.noreply.github.com>
Co-authored-by: Murali Ganesh <59461079+foxpro24@users.noreply.github.com>
Co-authored-by: Abilash Rangoju <988529+rangoju@users.noreply.github.com>
@petermeansrock
Copy link
Contributor Author

Per @kaizencc from aws/aws-cdk#22886:

Yay @petermeansrock, thanks for all your hard work and quick turn around time! This looks good to me, and means that your RFC design is fully implemented. Congrats! If you are willing/interested, it will be interesting to see what kind of usage + issues we get on this new L2 library and would be great to have your continued participation on those issues as they come in! I may try to ping you...

Marking this issue as completed. Thanks for all the help, Kaizen (as well as other RFC feedback providers)!

@petermeansrock
Copy link
Contributor Author

petermeansrock commented Nov 29, 2022 •
edited
Loading

Based on @kaizencc's recommendation, I've created issues on the CDK repository to cover the future feature additions documented in the RFC:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
management/tracking status/api-approved API Bar Raiser signed-off the API of this RFC status/implementing RFC is being implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petermeansrock @kaizencc