Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EFS: Support File System Policy #24042

Closed
2 tasks
cameron-dunn-sublime opened this issue Feb 7, 2023 · 2 comments · Fixed by #24196 · May be fixed by WontonSam/apollo-federation-subgraph-compatibility#508, WontonSam/apollo-federation-subgraph-compatibility#511 or WontonSam/apollo-federation-subgraph-compatibility#523
Closed
2 tasks

EFS: Support File System Policy #24042

cameron-dunn-sublime opened this issue Feb 7, 2023 · 2 comments · Fixed by #24196 · May be fixed by WontonSam/apollo-federation-subgraph-compatibility#508, WontonSam/apollo-federation-subgraph-compatibility#511 or WontonSam/apollo-federation-subgraph-compatibility#523
Labels
@aws-cdk/aws-efs Related to Amazon Elastic File System effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@cameron-dunn-sublime
Copy link

Describe the feature

The FileSystem construct does not support a File System Policy.

Use Case

This would make working with the FileSystem construct more useful, and would avoid needing to use escape hatches to associate a policy.

Proposed Solution

I believe this could simply be added as an additional property. Or an additional construct could allow associating a policy, similar to s3.BucketPolicy.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

0.2.63

Environment details (OS name and version, etc.)

OS X, not related
@cameron-dunn-sublime cameron-dunn-sublime added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 7, 2023
@github-actions github-actions bot added the @aws-cdk/aws-efs Related to Amazon Elastic File System label Feb 7, 2023
@pahud
Copy link
Contributor

pahud commented Feb 8, 2023

Yes, this seems to be a new L1 property and we could add it in the L2 props. Are you interested to submit a PR for that?

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Feb 8, 2023
@zorrofox zorrofox mentioned this issue Feb 16, 2023
Merged
@mergify mergify bot closed this as completed in #24196 Feb 16, 2023
mergify bot pushed a commit that referenced this issue Feb 16, 2023
@zorrofox
feat(efs): support file system policy (#24196)
5e0f44b 
Add support EFS File System Policy.

Closes #24042.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced Sep 13, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-efs Related to Amazon Elastic File System effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@pahud @cameron-dunn-sublime