Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-wafv2): Some structs naming pattern changed from Foo to FooAction #24668

Open
vinayak-kukreja opened this issue Mar 17, 2023 · 0 comments
Open
Assignees
Labels
@aws-cdk/aws-wafv2 bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@vinayak-kukreja
Copy link
Contributor

Describe the bug

aws_wafv2.CfnRuleGroup struct names were changed from Foo to FooAction recently. I see the name change in,

Looks like these were released in this PR.

Expected Behavior

These structs should instead just be without the Action suffix.

Current Behavior

These structs are currently with the Action suffix.

Reproduction Steps

You can see these name changes if you upgrade CDK V1 to either: v1.192.0 or CDK V2 to v2.63.0.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.69.0 (build 60a5b2a)

Framework Version

No response

Node.js Version

v14.19.3

OS

Mac OS

Language

Typescript

Language Version

No response

Other information

No response

@vinayak-kukreja vinayak-kukreja added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 17, 2023
@vinayak-kukreja vinayak-kukreja self-assigned this Mar 17, 2023
vinayak-kukreja added a commit to cdklabs/aws-cdk-notices that referenced this issue Mar 17, 2023
Signed-off-by: Vinayak Kukreja <vinakuk@amazon.com>
@pahud pahud added p1 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 17, 2023
mergify bot pushed a commit to cdklabs/aws-cdk-notices that referenced this issue Mar 17, 2023
CLI notice for WAFv2 RuleGroup struct name changes. 

Being patched here: aws/aws-cdk#24651
@pahud pahud added p2 and removed p1 labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-wafv2 bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

No branches or pull requests

2 participants