(aws-ecr-assets): TarballImageAsset Fails in Stage

[gilday]

Describe the bug

The TarballImageAsset construct fails when it is nested inside of a Stack that is also inside of a Stage. Moving that Stack outside of the Stage works around the issue.

Expected Behavior

The TarballImageAsset should push the image to ECR.

Current Behavior

The failure occurs when TarballImageAsset attempts to shell out to docker load.

[78%] fail: docker tag .dkr.ecr..amazonaws.com/cdk--container-assets--: exited with error code 1: Error parsing reference: "" is not a valid repository/tag: invalid reference format

Reproduction Steps

  class MyStack extends Stack {
    public MyStack(final Construct scope, final String id) {
      super(scope, id);
      new TarballImageAsset(
          this, "image", TarballImageAssetProps.builder().tarballFile("./my-image.tar").build());
    }
  }

  class MyStage extends Stage {
    public MyStage(final Construct scope, final String id) {
      super(scope, id);
      new MyStack(this, "stack");
    }
  }

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.70.0 (build c13a0f1)

Framework Version

2.70.0

Node.js Version

v19.8.1

OS

macOS 13.2.1

Language

Java

Language Version

17.0.6

Other information

Consider sending requests to the Docker daemon without shelling out to the Docker CLI to get more descriptive errors and avoid issues like #19627.

[pahud]

Unfortunately I can't get this reproduced.

I am using CDK in TypeScript as the following code:

class MyStack extends cdk.Stack {
  constructor(scope: Construct, id: string, props?: StackProps) {
    super(scope, id, props);
    new ecrassets.TarballImageAsset(this, "image",  {
      tarballFile: path.join(__dirname, '../demo.tar')
    });
  }
}

class MyStage extends cdk.Stage {
  constructor(scope: Construct, id: string) {
    super(scope, id)
    new MyStack(this, "mystack-test")
  }
}


new MyStage(app, 'mystage-dev')

I generate demo.tar by

$ docker pull busybox
$ docker save busybox -o demo.tar

I am not sure if it only happens in Java or is it tarball-specific. Can you generate a new tarball just as what I did above and see if the issue still exists?

[gilday]

The busybox image also fails in my application.

I tried building a reproducer (https://github.com/gilday/cdk-issue-24827), but I'm unable to reproduce whatever it is about my other project that makes this fail.

I'm on macOS, and in the Console, I see error messages from com.docker.backend that correspond to the cdk deploy failures.

(3364e464) 46760170-CLIAPI S<-C Go-http-client/1.1 bind: {"command":"tag","context":"moby","source":"cli","status":"failure"}

[lorenzo-shape]

I am experiencing the same (CDK v2.75.0).

I gave a look at the cdk repo (in particular packages/cdk-assets/lib/private/handlers/container-images.ts) and I think the error comes from where the .tar asset file is saved inside the cdk.out folder.

The file is saved at the root of the folder while the workDir for the docker command is set at cdk.out/assembly-[StageName]. So the docker load command fails returning an empty string for the docker tag command.

I tried to manually move the generated .tar asset file inside the cdk.out/assembly-[StageName] folder and the deployment worked.

[viktorvoltaire]

Any updates on this?

[pahud]

@viktorvoltaire

Are you able to reproduce this error using my code snippet here?