Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-synthetics-alpha): support latest canary runtime for NodeJS v4.0 #25493

Closed
1 of 2 tasks
wilhen01 opened this issue May 9, 2023 · 4 comments · Fixed by #25553
Closed
1 of 2 tasks

(aws-synthetics-alpha): support latest canary runtime for NodeJS v4.0 #25493

wilhen01 opened this issue May 9, 2023 · 4 comments · Fixed by #25553
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@wilhen01
Copy link
Contributor

wilhen01 commented May 9, 2023 •
edited
Loading

Describe the feature

AWS have just released runtime version 4.0 for Synthetics Canaries using NodeJS, which uses Node 16 rather than Node 14. All previous runtime versions will presumably be marked as deprecated soon since Node 14 is EOL.

CDK should expose the appropriate enum value for the new 4.0 runtime.

Use Case

Make latest runtime available and allow canaries to run on a supported Node version.

Proposed Solution

Add entry for the new runtime version to the Runtime class

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

v2.78.0

Environment details (OS name and version, etc.)

Mac OS
@wilhen01 wilhen01 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 9, 2023
@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label May 9, 2023
@pahud
Copy link
Contributor

pahud commented May 9, 2023 •
edited
Loading

Yes, we should add this enum value in the class. We'd love to review your PR when it's ready. Thank you.

@pahud pahud added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels May 9, 2023
@WinterYukky
Copy link
Contributor

@wilhen01
Oh... I'm sorry, I tried to support runtime version 4.0 few days ago and created #25553 today.
If you trying this issue, I'm sorry again.

@WinterYukky WinterYukky mentioned this issue May 12, 2023
Merged
@wilhen01
Copy link
Contributor Author

@WinterYukky no problem! I was going to look at this today but you've beaten me to it 😁

@mergify mergify bot closed this as completed in #25553 May 30, 2023
mergify bot pushed a commit that referenced this issue May 30, 2023
@WinterYukky
feat(synthetics): support runtime nodejs puppeteer 4.0 (#25553)
1d7a9a8 
## What change
Add CloudWatch Synthetics runtime nodejs puppeteer 4.0.

## Others
I changed integ test to using integ-tests assertions.

Closes #25493

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(synthetics): support runtime nodejs puppeteer 4.0 WinterYukky/aws-cdk
3 participants
@pahud @wilhen01 @WinterYukky