Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-ec2: Add feature to enable contributor insight rules for vpc endpoint service #25951

Closed
2 tasks
r0b0ji opened this issue Jun 13, 2023 · 4 comments
Closed
2 tasks

aws-ec2: Add feature to enable contributor insight rules for vpc endpoint service #25951

r0b0ji opened this issue Jun 13, 2023 · 4 comments
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@r0b0ji
Copy link

r0b0ji commented Jun 13, 2023

Describe the feature

Contributor insight rules can be enabled on Vpc ednpoint service through console. It should be possible to enable it through CDK, probably through VpcEndpointServiceProps.

Use Case

I want to enable contributor insight rules for vpc endpoint service.

Proposed Solution

Add a flag to VpcEndpointServiceProps to enable contributor insights rule. For ex: aws-ecs.ClusterProps.containerInsights

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.68

Environment details (OS name and version, etc.)

macos, amazon linux2
@r0b0ji r0b0ji added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 13, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Jun 13, 2023
@pahud
Copy link
Contributor

pahud commented Jun 13, 2023

Looks like we just need to expose the ContributorInsightsEnabled prop in VpcEndpointServiceProps.

@pahud pahud added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 13, 2023
@khushail khushail mentioned this issue Jun 14, 2023
Merged
@khushail
Copy link
Contributor

khushail commented Jun 15, 2023 •
edited
Loading

working on it.

This was referenced Jul 26, 2023
Closed
Closed
mergify bot pushed a commit that referenced this issue Aug 23, 2023
@khushail
feat(ec2): contributor insight rules for vpc endpoint service (#25965)
c6a96f0 
Closes #[25951](#25951)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@Leo10Gama
Copy link
Member

Closing this issue, as it seems like the PR above has resolved it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pahud @r0b0ji @Leo10Gama @khushail