Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(ses): create unit tests for drop spam handler #27726

Closed
2 tasks
colifran opened this issue Oct 27, 2023 · 1 comment · Fixed by #27769
Closed
2 tasks

(ses): create unit tests for drop spam handler #27726

colifran opened this issue Oct 27, 2023 · 1 comment · Fixed by #27769
Assignees
@colifran
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service feature-request A feature should be added or improved. p2

Comments

@colifran
Copy link
Contributor

Describe the feature

We need to improve testing coverage of our Lambda handlers. The Lambda handler for drop spam does not have corresponding unit tests. Unit tests should be created specifically for this handler.

Use Case

Unit tests for the drop spam Lambda handler would improve test coverage and help us find bugs and prevent breaking changes.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.103.1

Environment details (OS name and version, etc.)

MacOS
@colifran colifran added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 27, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ses Related to Amazon Simple Email Service label Oct 27, 2023
@colifran colifran added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Oct 27, 2023
@colifran colifran self-assigned this Oct 30, 2023
@colifran colifran mentioned this issue Oct 30, 2023
Merged
@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
@mergify mergify bot closed this as completed in #27769 Nov 3, 2023
mergify bot pushed a commit that referenced this issue Nov 3, 2023
@colifran
chore(ses): create unit tests for drop spam handler (#27769)
12fe361 
This PR adds unit tests for the SES drop spam handler. Specifically, the unit tests verify that spam will be dropped under the following conditions:

1. SPF verdict is `FAIL`
2. DKIM verdict is `FAIL`
3. Spam verdict is `FAIL`
4. Virus verdict is `FAIL`

An additional unit test was added to ensure that null is returned if all the above verdicts are not `FAIL`.

Closes #27726

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colifran colifran

Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ses): create unit tests for drop spam handler aws/aws-cdk
1 participant
@colifran