Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-ec2: for VpnConnection, tunnelInsideCidr is required if two tunnel options #27772

Closed
azatoth opened this issue Oct 31, 2023 · 2 comments · Fixed by #27778
Closed

aws-ec2: for VpnConnection, tunnelInsideCidr is required if two tunnel options #27772

azatoth opened this issue Oct 31, 2023 · 2 comments · Fixed by #27778
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@azatoth
Copy link
Contributor

azatoth commented Oct 31, 2023

Describe the bug

When setting up a VpnConnection and under tunnelOptions specify two VpnTunnelOptions, currently you are required to hard code two unique tunnelInsideCidr.

Expected Behavior

That the tunnelInsideCidr would be automatically generated for each of the tunnels

Current Behavior

CDK fails with following error:

Error: Same undefined `tunnelInsideCidr` cannot be used for both tunnels.

Reproduction Steps

var vpc = new Vpc( /* ... */ );
vpc.addVpnConnection(
      "MyVPC",
      VpnConnectionOptions
        .builder()
        .ip(VPN_HOST)
        .staticRoutes(VPN_PEERS)
        .tunnelOptions(
          ImmutableList.of(
            VpnTunnelOption.builder().preSharedKeySecret(vpnSecret.getSecretValue()).build(),
            VpnTunnelOption.builder().preSharedKeySecret(vpnBackupSecret.getSecretValue()).build()
          )
        )
        .build()
    );

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.95.1 (build ae455d8)

Framework Version

No response

Node.js Version

v18.14.2

OS

Linux

Language

Java

Language Version

No response

Other information

No response

@azatoth azatoth added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Oct 31, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Oct 31, 2023
@msambol
Copy link
Contributor

msambol commented Oct 31, 2023

I'll take this.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 31, 2023
@mergify mergify bot closed this as completed in #27778 Nov 2, 2023
mergify bot pushed a commit that referenced this issue Nov 2, 2023
Closes #27772.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

github-actions bot commented Nov 2, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants