Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api-gateway: support kinesis firehose as access log destination in aws-cdk-lib.aws_apigateway.StageOptions #27954

Closed
2 tasks
p3tek opened this issue Nov 13, 2023 · 3 comments · Fixed by #27959
Closed
2 tasks

api-gateway: support kinesis firehose as access log destination in aws-cdk-lib.aws_apigateway.StageOptions #27954

p3tek opened this issue Nov 13, 2023 · 3 comments · Fixed by #27959
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@p3tek
Copy link

p3tek commented Nov 13, 2023

Describe the feature

Kinesis firehose is an option for access logging through AWS console:
https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-logging-to-kinesis.html

Currently only cdk.aws_apigateway.IAccessLogDestination is accepted for accessLogDestination in aws-cdk-lib.aws_apigateway.StageOptions with no way option of providing a firehose data stream meaning only Cloudwatch logs is possible for access logs

Use Case

I want to be able to use cdk to deploy an rest api with kinesis firehose as an access logging destination

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.87.0

Environment details (OS name and version, etc.)

linux
@p3tek p3tek added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 13, 2023
@github-actions github-actions bot added the @aws-cdk/aws-apigateway Related to Amazon API Gateway label Nov 13, 2023
@lpizzinidev lpizzinidev mentioned this issue Nov 13, 2023
Merged
@khushail khushail added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 13, 2023
@khushail
Copy link
Contributor

Thanks @p3tek for submitting this feature request.
Thanks @lpizzinidev for submitting a PR. Appreciate your contribution.

@p3tek
Copy link
Author

p3tek commented Nov 14, 2023

Thanks for raising the PR @lpizzinidev

mergify bot added a commit to lpizzinidev/aws-cdk that referenced this issue Nov 14, 2023
@mergify
Merge branch 'main' into awsgh-27954
5fcc895
@mergify mergify bot closed this as completed in #27959 Nov 14, 2023
mergify bot pushed a commit that referenced this issue Nov 14, 2023
@lpizzinidev
feat(apigateway): support firehose access log destination (#27959)
33357aa 
Adds support for Firehose delivery stream as access log destination of API gateway.

Closes #27954.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-apigateway Related to Amazon API Gateway effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(apigateway): support firehose access log destination lpizzinidev/aws-cdk
2 participants
@p3tek @khushail