refactor(appsync): abstract schema stringify to utility functions #10019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic into one function
shivlaks
suggested changes
Aug 27, 2020
shivlaks
reviewed
Aug 27, 2020
Comment on lines
28
to
39
| /** | ||
| * the name for this addition (some additions dont need this [i.e. schema]) | ||
| */ | ||
| readonly name?: string; | ||
| /** | ||
| * the interface types if this is creating an object type | ||
| */ | ||
| readonly interfaceTypes?: InterfaceType[]; | ||
| /** | ||
| * the directives for this type | ||
| */ | ||
| readonly directives?: Directive[]; |
There was a problem hiding this comment.
add defaults for the optional properties (if any). this is mainly for posterity
shivlaks
approved these changes
Aug 27, 2020
…ws-cdk into refactor-stringify
BryanPan342
changed the title
BryanPan342
removed
the
pr/do-not-merge
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract schema addition to utility functions in
private.tsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license