Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for the 'Version' resource attribute #10376

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

skinny85
Copy link
Contributor

As it turns out, there's one more resource attribute that we don't support currently:
Version, used for custom CloudFormation resources.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

As it turns out, there's one more resource attribute that we don't support currently:
Version, used for custom CloudFormation resources.
@skinny85 skinny85 self-assigned this Sep 15, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 15, 2020
@skinny85 skinny85 added pr/do-not-merge This PR should not be merged at this time. pr-linter/exempt-readme The PR linter will not require README changes and removed pr/do-not-merge This PR should not be merged at this time. labels Sep 17, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ab251ab
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit aac235a into aws:master Sep 17, 2020
@skinny85 skinny85 deleted the faeat/version-resource-attribute branch September 17, 2020 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants