Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stepfunctions-tasks): add missing braces #10406

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Sep 17, 2020

Add missing braces around if added in #10386


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add missing braces around `if` added in aws#10386
@jogold
Copy link
Contributor Author

jogold commented Sep 17, 2020

@shivlaks just saw that I forgot braces around the if in #10386 and I don't like this style...

@shivlaks
Copy link
Contributor

@shivlaks just saw that I forgot braces around the if in #10386 and I don't like this style...

no worries, i should have caught that. thanks for fixing as a chore

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

jogold added a commit to jogold/aws-cdk that referenced this pull request Sep 17, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 406b84d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 483e319 into aws:master Sep 17, 2020
@jogold jogold deleted the patch-1 branch September 17, 2020 10:44
mergify bot pushed a commit that referenced this pull request Sep 17, 2020
…10408)

Avoid things like #10406

See https://eslint.org/docs/rules/curly#multi-line

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants