Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudwatch): LTE operator renders wrong symbol #10418

Merged
merged 3 commits into from
Sep 21, 2020
Merged

Conversation

alvyn279
Copy link
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

- Fixed incorrect comparison operator (LTE) string from '>=' to '<='
- fixes aws#8913
@rix0rrr rix0rrr added the pr-linter/exempt-test The PR linter will not require test changes label Sep 21, 2020
@rix0rrr rix0rrr changed the title fix(cloudwatch): fixed lte operator string for alarms annotations label fix(cloudwatch): LTE operator renders wrong symbol Sep 21, 2020
rix0rrr
rix0rrr previously approved these changes Sep 21, 2020
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! But please add a test

@mergify mergify bot dismissed rix0rrr’s stale review September 21, 2020 08:42

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 6822b46
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2543584 into aws:master Sep 21, 2020
@alvyn279 alvyn279 deleted the 8913 branch September 21, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aws-cloudwatch] Incorrect comparison operator for alarm annotation label
3 participants