Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): add @amzn to version reporting #10437

Merged
merged 3 commits into from
Sep 21, 2020
Merged

chore(core): add @amzn to version reporting #10437

merged 3 commits into from
Sep 21, 2020

Conversation

NetaNir
Copy link
Contributor

@NetaNir NetaNir commented Sep 18, 2020 •
edited
Loading

Add the amzn scope to our version reporting, owned by Amazon: https://www.npmjs.com/org/amzn

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 18, 2020
@NetaNir NetaNir requested a review from eladb September 18, 2020 21:27
@skinny85
Copy link
Contributor

Tagging @rix0rrr as well.

@eladb
Copy link
Contributor

eladb commented Sep 21, 2020

Title is not clear- add scope to what?

@eladb
Copy link
Contributor

eladb commented Sep 21, 2020

Do we own this npm scope?

@NetaNir NetaNir changed the title chore(core): add amzn scope chore(core): add amzn scope to version reporting Sep 21, 2020
@NetaNir
Copy link
Contributor Author

NetaNir commented Sep 21, 2020

Updated the title.
Yes we own the scope https://www.npmjs.com/org/amzn

@NetaNir NetaNir changed the title chore(core): add amzn scope to version reporting chore(core): add @amzn to version reporting Sep 21, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b22cd08 into master Sep 21, 2020
@mergify mergify bot deleted the neta/add-amzn branch September 21, 2020 07:45
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d5f0cc3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eladb eladb eladb approved these changes

@skinny85 skinny85 Awaiting requested review from skinny85

@rix0rrr rix0rrr Awaiting requested review from rix0rrr

Assignees

@rix0rrr rix0rrr

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NetaNir @skinny85 @eladb @aws-cdk-automation @rix0rrr