chore(integ): run all CDK integ tests with -v
#10503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we suppress output of non-failing tests, it becomes all the more important to have detailed information for failing tests.
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
rix0rrr
changed the title
-v-v
NetaNir
approved these changes
Sep 24, 2020
iliapolo
reviewed
Sep 24, 2020
| @@ -178,7 +178,7 @@ export class TestFixture { | |||
| } | |||
|
|
|||
| public async cdk(args: string[], options: CdkCliOptions = {}) { | |||
| return this.shell(['cdk', ...args], { | |||
| return this.shell(['cdk', '-v', ...args], { | |||
There was a problem hiding this comment.
@rix0rrr To see these logs in the regression suites for the current release this needs to be patched to the previous tests as well..added do-not-merge
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
added a commit
that referenced
this pull request
Sep 24, 2020
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2020
Reverts #10503 We can't actually do this. There are tests that check that the output of the `cdk` command is *exactly* "some value", and adding the logging in breaks the expectation. Revert the `-v` to allow the tests to go back to passing 90% of the time.
mergify bot
pushed a commit
that referenced
this pull request
Sep 25, 2020
Following up on #10503, enabling verbose logging for integ tests. opt out for tests that relies on exact match of the output: * 'cdk synth' - match the output of `synth`. * 'Two ways of shoing the version' - This one is tricker. Since `--version` is implemnted using `.version()` of `yargs` it ignores the `-v` argument, but `version` (no dash) which is our implementation respect it. ``` $cdk version -v CDK toolkit version: 1.63.0 (build 7a68125) .... blah blah ``` vs: ``` $cdk --version -v 1.63.0 (build 7a68125) ``` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we suppress output of non-failing tests, it becomes
all the more important to have detailed information for failing tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license