fix(pipelines): stack tags #10533
fix(pipelines): stack tags #10533
Conversation
Apply stack tags to the stacks deployed using CDK Pipelines. Fixes #9260.
|
(Not ready to be merged yet, needs more tests--specifically around CLI backwards compatibility of still reading tags from old assemblies) |
| import * as path from 'path'; | ||
|
|
||
| /** | ||
| * rm -rf reimplementation, don't want to depend on an NPM package for this |
There was a problem hiding this comment.
What's wrong with using an npm package for tests?
There was a problem hiding this comment.
Let's see. I can either have this 10-line function or
└─┬ rimraf@3.0.2
└─┬ glob@7.1.6
├── fs.realpath@1.0.0
├─┬ inflight@1.0.6
│ ├── once@1.4.0 deduped
│ └── wrappy@1.0.2
├── inherits@2.0.4
├─┬ minimatch@3.0.4
│ └─┬ brace-expansion@1.1.11
│ ├── balanced-match@1.0.0
│ └── concat-map@0.0.1
├─┬ once@1.4.0
│ └── wrappy@1.0.2 deduped
└── path-is-absolute@1.0.1
| fullConfigPath = `${fullTemplatePath}.config.json`; | ||
|
|
||
| // Write the template configuration file (for parameters into CreateChangeSet call that | ||
| // cannot be configured any other way). They must come from a file, and there's unfortunately |
There was a problem hiding this comment.
Feels like this would be an excellent case for a construct adding an artifact to the synthesized output of a cloud assembly, as an implementation detail of the construct.
What's happening now is that we're writing a file which is right next to another file that we assume is going to be in a cloud assembly, of which we kinda guess the name is probably going to be unused, which is invisible any of the rest of the framework.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Apply stack tags to the stacks deployed using CDK Pipelines.
Taking this opportunity to make tags easier to work with -- move them from metadata into cloud artifact properties.
Fixes #9260.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license