-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(synthetics): syn-nodejs-2.0 runtime #10574
Conversation
`syn-nodejs-2.0` is the latest runtime. See https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_Library.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! didn't realize this was out already
/** | ||
* `syn-nodejs-2.0` includes the following: | ||
* - Lambda runtime Node.js 10.x | ||
* - Puppeteer-core version 3.3.0 | ||
* - Chromium version 81.0.4044.0 | ||
*/ | ||
public static readonly SYNTHETICS_NODEJS_2_0 = new Runtime('syn-nodejs-2.0'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably also worth an
@see https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_Library.html#CloudWatch_Synthetics_runtimeversion-2.0`
to help users make the decision on which runtime fits their use case.
should we also update this doc string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, bad link from me - doc string
I suppose it is experimental so we could still update the default runtime if it's the sensible thing we want to nudge users towards. thoughts @NetaNir ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think that since we are still in the experimental phase it make sense to change it
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
syn-nodejs-2.0
is the latest runtime.See https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/CloudWatch_Synthetics_Canaries_Library.html
BREAKING CHANGE: the default runtime is now
syn-nodejs-2.0
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license