Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cognito): callback URLs are specified when OAuth is disabled for user pool clients #10588

Merged
merged 3 commits into from
Sep 30, 2020
Merged

fix(cognito): callback URLs are specified when OAuth is disabled for user pool clients #10588

merged 3 commits into from
Sep 30, 2020

Commits on Sep 29, 2020

  1. fix(cognito): callback URLs are specified when OAuth is disabled for … 

    …user pool clients

When the `UserPoolClient` property `disableOAuth` is set, callback URLs should not be
rendered as it represents a list of allowed redirects for identity providers.

Added in a condition that only renders the callback URL default of `https://example.com`
if OAuth is enabled.

Closes #10311
    @shivlaks
    shivlaks committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    7e1c015 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. update test to validate that callbackURLs property is absent

    @shivlaks
    shivlaks committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    b879e23 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into shivlaks/cognito-callbackurls

    @mergify
    mergify[bot] authored Sep 30, 2020
    Configuration menu
    Copy the full SHA
    4d382e0 View commit details
    Browse the repository at this point in the history