Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate constructs to use "constructs" module #10606

Merged
merged 26 commits into from
Oct 1, 2020

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Sep 30, 2020

This commits expands on a previous commit. The remaining
CDK modules have been migrated to use the Construct and
IConstruct from the "constructs" module instead of the
"@aws-cdk/core" module.

Migrating modules to use the "constructs" module, prevents merge
conflicts from arising in these files when the construct compatibility
layer in "@aws-cdk/core" module is removed in the v2 branch.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nija-at nija-at self-assigned this Sep 30, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 30, 2020
@nija-at nija-at marked this pull request as ready for review October 1, 2020 08:16
@nija-at nija-at requested review from eladb and a team October 1, 2020 08:16
@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: bfeca71
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 1, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 60c782f into master Oct 1, 2020
@mergify mergify bot deleted the nija-at/constructcompat-wave2 branch October 1, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants