Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core,cx-api): docker bundling fails during tests on macOS #10620

Merged
merged 2 commits into from
Oct 1, 2020
Merged

fix(core,cx-api): docker bundling fails during tests on macOS #10620

merged 2 commits into from
Oct 1, 2020

Commits on Oct 1, 2020

  1. fix(cx-api): docker bundling fails during tests on macOS 

    When running unit tests `outdir` defaults to a temporary directory in
the system temp directory. On macOS `os.tmpdir()` is a symlink so
bundling in Docker fails.

Fix it by using `fs.realpathSync`.

Closes aws#10262
    @jogold
    jogold committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    70bf91e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into macos-bundling-test

    @mergify
    mergify[bot] authored Oct 1, 2020
    Configuration menu
    Copy the full SHA
    0fc0dc7 View commit details
    Browse the repository at this point in the history