chore(cdk-build-tools): print build times for all packages #10681
Conversation
Print the build times for all packages, irrespective of their success or failure. The motivation is to gather package build times and their contribution to the total build time of the repo.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
It will be nice to have in the logs, but not ideal to do analysis of the build time. How about we collect the times as and report as cloudwatch metrics? |
| process.stderr.write('!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n'); | ||
| process.exit(1); | ||
| }).finally(() => { | ||
| buildTimer.end(); | ||
| process.stdout.write(`Build times for ${currentPackageJson().name}: ${timers.display()}\n`); |
There was a problem hiding this comment.
Would it make more sense to accumulate (eg in a file) and print a summary report at the end of the full build?
Otherwise I can't really see how this is usable
There was a problem hiding this comment.
Otherwise I can't really see how this is usable
Download the build log and run a grep on 'Build times ' ?
Maybe yes, but that's more than what I need right now. This is very simple at the moment. I just want to get a single snapshot of which packages consume how much time. |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Print the build times for all packages, irrespective of their success or
failure.
The motivation is to gather package build times and their contribution
to the total build time of the repo.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license