fix(cloudfront-origins): S3Origins with cross-stack buckets cause cyclic references #10696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lic references An S3Origin creates an OriginAccessIdentity, and grants that identity read permissions on the bucket. This creates cyclic references when the bucket is located in a different stack than the distribution. The bucket has a dependency on the generated OAI user for the BucketPolicy, and the Distribution has a dependency on the bucket's domain name for the origin. The fix detects a cross-stack bucket and re-parents the OAI in the bucket's stack to prevent cyclic references. fixes #10399
rix0rrr
approved these changes
Oct 5, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An S3Origin creates an OriginAccessIdentity, and grants that identity read
permissions on the bucket. This creates cyclic references when the bucket is
located in a different stack than the distribution. The bucket has a dependency
on the generated OAI user for the BucketPolicy, and the Distribution has a
dependency on the bucket's domain name for the origin.
The fix detects a cross-stack bucket and re-parents the OAI in the bucket's
stack to prevent cyclic references.
fixes #10399