chore: migrate all tests off compat layer and use "constructs" module #10698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 5, 2020 14:17
nija-at
force-pushed
the
nija-at/eslint-testing
branch
from
12109be
to
9c70cfc
Compare
rix0rrr
approved these changes
Oct 5, 2020
eladb
reviewed
Oct 5, 2020
packages/@aws-cdk/app-delivery/test/test.pipeline-deploy-stack-action.ts
Show resolved
Hide resolved
eladb
reviewed
Oct 5, 2020
eladb
approved these changes
Oct 5, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching all tests and test utilities to use the "constructs" module
as preparation for v2 branch. As part of CDKv2, the construct compat
layer in the "@aws-cdk/core" module will be removed.
This change pre-migrates tests to the new module so as to reduce code
divergence between the 'v1' and 'v2' code branches. This will in turn
reduce the number of merge conflicts when changes are forward merged
from the 'v1' branch onto the 'v2' branch.
This change also adds a new private tools module - eslint-plugin-cdk -
where CDK specific eslint rules can be added. The first rule now is to
ensure that tests and test related utilities do not use the construct
compat layer.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license