Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update module ownership #11967

Merged
merged 7 commits into from
Dec 16, 2020
Merged

chore: update module ownership #11967

merged 7 commits into from
Dec 16, 2020

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Dec 9, 2020

Updating module assignment to remove most ownership from @shivlaks.

Tagging: @nija-at , @rix0rrr , @iliapolo , @skinny85 , and @njlynch

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@njlynch
chore: update module ownership
28e3f62 
Updating module assignment to remove most ownership from shivlaks@.
@njlynch njlynch added the pr/do-not-merge This PR should not be merged at this time. label Dec 9, 2020
@njlynch njlynch requested a review from a team December 9, 2020 17:35
@njlynch njlynch self-assigned this Dec 9, 2020
@gitpod-io
Copy link

gitpod-io bot commented Dec 9, 2020 •
edited
Loading

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 9, 2020
nija-at
nija-at approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provisional.

@njlynch @NetaNir
Applying Neta's volunteer assignments
f0f7627 
Co-authored-by: Neta Nir <neta1nir@gmail.com>
@njlynch njlynch removed the pr/do-not-merge This PR should not be merged at this time. label Dec 10, 2020
@mergify
Copy link
Contributor

mergify bot commented Dec 10, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@NetaNir
Copy link
Contributor

NetaNir commented Dec 11, 2020

Sorry @njlynch, fixed now!

@mergify
Copy link
Contributor

mergify bot commented Dec 11, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: d1afe59
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@njlynch njlynch merged commit 607d320 into master Dec 16, 2020
@njlynch njlynch deleted the njlynch/update-ownership branch December 16, 2020 18:22
hassanazharkhan added a commit to hassanazharkhan/aws-cdk that referenced this pull request Dec 16, 2020
@hassanazharkhan
Merge pull request #1 from aws/master
96d8670 
chore: update module ownership (aws#11967)
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
@njlynch @flochaz
chore: update module ownership (aws#11967)
99f40d8 
Updating module assignment to remove most ownership from shivlaks@.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericzbeard ericzbeard ericzbeard left review comments

@NetaNir NetaNir NetaNir left review comments

@nija-at nija-at nija-at approved these changes

@shivlaks shivlaks shivlaks approved these changes

Assignees

@njlynch njlynch

Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@njlynch @NetaNir @aws-cdk-automation @ericzbeard @nija-at @shivlaks