feat(lambda-nodejs): Expose optional props for advanced usage of esbuild #12123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jogold
suggested changes
Dec 17, 2020
jogold
reviewed
Dec 17, 2020
hassanazharkhan
force-pushed
the
hassanazharkhan/expose_esbuild_option
branch
from
e2d3f97
to
e4233cd
Compare
jogold
reviewed
Dec 17, 2020
hassanazharkhan
force-pushed
the
hassanazharkhan/expose_esbuild_option
branch
from
b66b8d1
to
8a74e36
Compare
hassanazharkhan
force-pushed
the
hassanazharkhan/expose_esbuild_option
branch
from
8a74e36
to
4c5623e
Compare
jogold
approved these changes
Dec 17, 2020
|
@hassanazharkhan can you merge from master (update your branch)? then the build will pass. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Dec 21, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
…ild (aws#12123) 1. Normally the build API automatically discovers tsconfig.json files and reads their contents during a build. However, we can also configure a custom tsconfig.json file to use instead for advanced use cases. 2. Added option to generate meta-file. 3. Added option to add comments in the bundled files Closes [12122](aws#12122) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally the build API automatically discovers tsconfig.json files and reads their contents during a build. However, we can also configure a custom tsconfig.json file to use instead for advanced use cases.
Added option to generate meta-file.
Added option to add comments in the bundled files
Closes 12122
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license