Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logs): Fix typo #12133

Merged
merged 4 commits into from
Dec 17, 2020
Merged

chore(logs): Fix typo #12133

merged 4 commits into from
Dec 17, 2020

Conversation

deepyaman
Copy link
Contributor


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 17, 2020

@mergify
Copy link
Contributor

mergify bot commented Dec 17, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@@ -154,7 +154,7 @@ abstract class LogGroupBase extends Resource implements ILogGroup {
}

/**
* Give permissions to write to create and write to streams in this log group
* Give permissions to create and write to streams in this log group
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Give permissions to create and write to streams in this log group
* Give permissions to create and write to streams in this log group

@deepyaman deepyaman changed the title Fix typo docs: Fix typo Dec 17, 2020
@SomayaB SomayaB self-assigned this Dec 17, 2020
@SomayaB SomayaB changed the title docs: Fix typo chore(logs): Fix typo Dec 17, 2020
@github-actions github-actions bot added the @aws-cdk/aws-logs Related to Amazon CloudWatch Logs label Dec 17, 2020
Copy link
Contributor

@SomayaB SomayaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks 👍

@mergify
Copy link
Contributor

mergify bot commented Dec 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Dec 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7a120f3 into aws:master Dec 17, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f11ffda
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@deepyaman deepyaman deleted the patch-1 branch December 29, 2020 20:04
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-logs Related to Amazon CloudWatch Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants