feat(signer): graduate to stable #13661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudFormation supports only one resource type for AWS Signer, namely [Signing Profile]. This is a very simple resource type with effectively two properties, both of which, have been modeled according to the latest expectations of the CDK construct library. There is no good reason why this module ought to stay as experimental. Given the standard nature of this module, I do not expect much customer feedback on usability that would require backwards incompatible changes. Hence, marking this as stable. Motivation The `ISigner` interface is referenced by the `Function` construct in the `aws-lambda` module. This is an instance of a stable module depending on an experimental module. In CDKv2, we plan to ship only stable modules as part of the mono-release of the cdk (aka, `aws-cdk-lib`). A prerequisite to achieve this is to avoid such dependencies (stable → experimental). In this specific case, we are fixing this by promoting the `aws-signer` module to stable. [Signing Profile]: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-signer-signingprofile.html
|
|
eladb
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Updated PR title to "feat" so it appears in changelog |
nija-at
added
pr/do-not-merge
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
yay! |
NetaNir
approved these changes
Mar 18, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
pushed a commit
that referenced
this pull request
Mar 24, 2021
CloudFormation supports only one resource type for AWS Signer, namely [Signing Profile]. This is a very simple resource type with effectively two properties, both of which, have been modeled according to the latest expectations of the CDK construct library. There is no good reason why this module ought to stay as experimental. Given the standard nature of this module, I do not expect much customer feedback on usability that would require backwards incompatible changes. Hence, marking this as stable. Motivation The `ISigner` interface is referenced by the `Function` construct in the `aws-lambda` module. This is an instance of a stable module depending on an experimental module. In CDKv2, we plan to ship only stable modules as part of the mono-release of the cdk (aka, `aws-cdk-lib`). A prerequisite to achieve this is to avoid such dependencies (stable → experimental). In this specific case, we are fixing this by promoting the `aws-signer` module to stable. [Signing Profile]: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-signer-signingprofile.html
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
CloudFormation supports only one resource type for AWS Signer, namely [Signing Profile]. This is a very simple resource type with effectively two properties, both of which, have been modeled according to the latest expectations of the CDK construct library. There is no good reason why this module ought to stay as experimental. Given the standard nature of this module, I do not expect much customer feedback on usability that would require backwards incompatible changes. Hence, marking this as stable. Motivation The `ISigner` interface is referenced by the `Function` construct in the `aws-lambda` module. This is an instance of a stable module depending on an experimental module. In CDKv2, we plan to ship only stable modules as part of the mono-release of the cdk (aka, `aws-cdk-lib`). A prerequisite to achieve this is to avoid such dependencies (stable → experimental). In this specific case, we are fixing this by promoting the `aws-signer` module to stable. [Signing Profile]: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-signer-signingprofile.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloudFormation supports only one resource type for AWS Signer, namely
Signing Profile.
This is a very simple resource type with effectively two properties,
both of which, have been modeled according to the latest expectations of
the CDK construct library.
There is no good reason why this module ought to stay as experimental.
Given the standard nature of this module, I do not expect much customer
feedback on usability that would require backwards incompatible changes.
Hence, marking this as stable.
Motivation
The
ISignerinterface is referenced by theFunctionconstruct in theaws-lambdamodule. This is an instance of a stable module depending onan experimental module.
In CDKv2, we plan to ship only stable modules as part of the
mono-release of the cdk (aka,
aws-cdk-lib). A prerequisite to achievethis is to avoid such dependencies (stable → experimental).
In this specific case, we are fixing this by promoting the
aws-signermodule to stable.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license