Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): respect LogGroup's region for aws-log-driver #18212

Merged
merged 6 commits into from
Jan 13, 2022

Conversation

kornicameister
Copy link
Contributor

Respect passed log group region when constructing an instance of AwsLogDriver.
That change allows to implement cross region logging pattern for ECS containers.

fixes #17747


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 29, 2021

@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Dec 29, 2021
@kornicameister
Copy link
Contributor Author

cc @skinny85 @gshpychka

Respect passed log group `region` when constructing an instance of `AwsLogDriver`.
That change allows to implement cross region logging pattern for ECS containers.

fixes aws#17747
@kornicameister
Copy link
Contributor Author

Alright, let's see if that one works now.

@kornicameister
Copy link
Contributor Author

@madeline-k @skinny85 thanks to fix from another issue, this change now allows to have correct region when using imported log group.
Cheers 👍

Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this fix, @kornicameister ! Looks great, I just have one tiny suggestion.

packages/@aws-cdk/aws-ecs/test/aws-log-driver.test.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed madeline-k’s stale review January 13, 2022 00:59

Pull request has been modified.

madeline-k
madeline-k previously approved these changes Jan 13, 2022
Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied my small suggestion myself. Approving! Thanks, @kornicameister!

@mergify mergify bot dismissed madeline-k’s stale review January 13, 2022 00:59

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b6e3e51 into aws:master Jan 13, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 88f9461
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kornicameister kornicameister deleted the fix_17747 branch January 13, 2022 08:47
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Respect passed log group `region` when constructing an instance of `AwsLogDriver`.
That change allows to implement cross region logging pattern for ECS containers.

fixes aws#17747

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ecs): AwsLogDriver ignores log group's region
3 participants