Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix dotnet -p deprecation warning #18632

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

Plasma
Copy link
Contributor

@Plasma Plasma commented Jan 24, 2022

Overview

Replace usage of -p with --project for dotnet run to resolve deprecation warning (NETSDK1174).

This appears during AWS CDK usage under .NET (C#, F#).

The full error message is similar to the following example:

The abbreviation of -p for --project is deprecated. Please use --project.

The use of -p in dotnet run is deprecated because of the close relationship dotnet run has with dotnet build and dotnet publish. In dotnet build and dotnet publish, p is used to set MSBuild properties. This deprecation is the first step in aligning abbreviations for these three commands.

Resolves #18092

References

See https://docs.microsoft.com/en-us/dotnet/core/tools/sdk-errors/netsdk1174


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 24, 2022

@mergify
Copy link
Contributor

mergify bot commented Jan 24, 2022

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

Copy link
Contributor

@peterwoodworth peterwoodworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thank you very much!

@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@peterwoodworth peterwoodworth changed the title Fix "dotnet run -p" (change to --project) deprecation warning chore: fix dotnet -p deprecation warning Jan 26, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 8fdfa8f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 031c742 into aws:master Jan 26, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

LukvonStrom pushed a commit to LukvonStrom/aws-cdk that referenced this pull request Jan 26, 2022
# Overview
Replace usage of `-p` with `--project` for `dotnet run` to resolve deprecation warning (`NETSDK1174`).

This appears during AWS CDK usage under .NET (C#, F#).

The full error message is similar to the following example:

> The abbreviation of -p for --project is deprecated. Please use --project.

> The use of -p in dotnet run is deprecated because of the close relationship dotnet run has with dotnet build and dotnet publish. In dotnet build and dotnet publish, p is used to set MSBuild properties. This deprecation is the first step in aligning abbreviations for these three commands.

Resolves aws#18092

# References
See https://docs.microsoft.com/en-us/dotnet/core/tools/sdk-errors/netsdk1174

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
# Overview
Replace usage of `-p` with `--project` for `dotnet run` to resolve deprecation warning (`NETSDK1174`).

This appears during AWS CDK usage under .NET (C#, F#).

The full error message is similar to the following example:

> The abbreviation of -p for --project is deprecated. Please use --project.

> The use of -p in dotnet run is deprecated because of the close relationship dotnet run has with dotnet build and dotnet publish. In dotnet build and dotnet publish, p is used to set MSBuild properties. This deprecation is the first step in aligning abbreviations for these three commands.

Resolves aws#18092

# References
See https://docs.microsoft.com/en-us/dotnet/core/tools/sdk-errors/netsdk1174

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDK V2 for .NET displays warning for -p usage from .NET 6 SDK
3 participants