Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix(custom-resources): Custom resource provider framework not passing ResponseURL to user function" #21109

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Revert "fix(custom-resources): Custom resource provider framework not passing ResponseURL to user function" #21109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/@aws-cdk/custom-resources/lib/provider-framework/runtime/framework.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,9 @@ async function invokeUserFunction<A extends { ResponseURL: '...' }>(functionArnE
// automatically by the JavaScript SDK.
const resp = await invokeFunction({
FunctionName: functionArn,
Payload: JSON.stringify(sanitizedPayload),

// Strip 'ResponseURL' -- the downstream CR doesn't need it and can only log it by accident
Payload: JSON.stringify({ ...sanitizedPayload, ResponseURL: undefined }),
});

log('user function response:', resp, typeof(resp));
Expand Down