chore(linter): require a test label for CLI changes #22187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require a label a human must add for PRs that change CLI code. The linter will give instructions on how to push the code to the right pipeline branch. Also add strong typing to the linter, there were a couple of bugs in there because of the `any`s.
|
|
Naumel
approved these changes
Sep 22, 2022
tools/@aws-cdk/prlint/lint.ts
Outdated
Comment on lines
385
to
394
| function noCliChanges(pr: GitHubPr, files: GitHubFile[]): TestResult { | ||
| const branch = `pull/${pr.number}/head`; | ||
|
|
||
| const cliCodeChanged = files.some(f => f.filename.toLowerCase().includes('/packages/aws-cdk/lib/') && f.filename.endsWith('.ts')); | ||
|
|
||
| return TestResult.fromFailure( | ||
| cliCodeChanged, | ||
| `CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin ${branch} && git push -f origin FETCH_HEAD:test-main-pipeline), then add the '${Exemption.CLI_INTEG_TESTED}' label when the pipeline succeeds.`); | ||
| } | ||
|
|
|
Mentioning #22175 here due to the output |
Naumel
approved these changes
Sep 22, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Dec 1, 2022
Require a label a human must add for PRs that change CLI code. The linter will give instructions on how to push the code to the right pipeline branch. Also add strong typing to the linter, there were a couple of bugs in there because of the `any`s. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require a label a human must add for PRs that change CLI code. The linter will give instructions on how to push the code to the right pipeline branch.
Also add strong typing to the linter, there were a couple of bugs in there because of the
anys.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license