Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ecs): update docs on cpu and memory limits #22209

Merged
merged 2 commits into from
Sep 23, 2022
Merged

docs(ecs): update docs on cpu and memory limits #22209

merged 2 commits into from
Sep 23, 2022

Conversation

watany-dev
Copy link
Contributor

Added a document to expand the cpu to 16vcpu and memory to 120GB that can be set in fargate.

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 23, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team September 23, 2022 12:54
@github-actions github-actions bot added p2 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Sep 23, 2022
@github-actions github-actions bot added the valued-contributor [Pilot] contributed between 6-12 PRs to the CDK label Sep 23, 2022
@kaizencc
Copy link
Contributor

Hi @watany-dev! Thank you for being one of the first to try out the merit badger pilot program! I made an embarrassing error in the github action that caused you to get admired instead of valued. I hope that doesn't deter you from continuing to contribute! You have 9 successful contributions (putting you in the 6-12 bucket) and with a couple more, you'll be admired.

@kaizencc kaizencc removed the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Sep 23, 2022
@watany-dev
Copy link
Contributor Author

watany-dev commented Sep 23, 2022 •
edited
Loading

@kaizencc
Thanks! I am glad my efforts were helpful. I will try to be a real admired again:)

@kaizencc kaizencc changed the title chore(ecs): Added a document to expand the cpu and memory docs(ecs): update docs on cpu and memory limits Sep 23, 2022
kaizencc
kaizencc approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4a82577
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 34c7b9e into aws:main Sep 23, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@watany-dev watany-dev deleted the fargate-validator-cpuAndMemory branch September 23, 2022 16:36
@watany-dev watany-dev mentioned this pull request Sep 26, 2022
Closed
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Dec 1, 2022
@watany-dev @madeline-k
docs(ecs): update docs on cpu and memory limits (aws#22209)
d95ba19 
Added a document to expand the cpu to 16vcpu and memory to 120GB that can be set in fargate.

- Reference URL
    - https://docs.aws.amazon.com/AmazonECS/latest/developerguide/task-cpu-memory-error.html
    - https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-ecs-taskdefinition.html#cfn-ecs-taskdefinition-cpu
    - https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-ecs-taskdefinition.html#cfn-ecs-taskdefinition-memory


----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees
No one assigned
Labels
p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@watany-dev @kaizencc @aws-cdk-automation