Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mergify): add Hogan as team member #22870

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Conversation

HBobertz
Copy link
Contributor

@HBobertz HBobertz commented Nov 10, 2022


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 10, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team November 10, 2022 18:09
@github-actions github-actions bot added the p2 label Nov 10, 2022
@HBobertz HBobertz changed the title adding Hogan to team members chore(mergify): add Hogan to team members Nov 10, 2022
@mergify mergify bot mentioned this pull request Nov 10, 2022
4 tasks
@HBobertz HBobertz changed the title chore(mergify): add Hogan to team members chore(mergify): add Hogan as team member Nov 10, 2022
@kaizencc
Copy link
Contributor

@HBobertz there's another place that this needs to get added - .github/workflwos/github-merit-badger.yml. If that's not part of the onboarding docs, that's my bad -- perhaps you can add it there too?

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh also lets target the main branch :) edit: andddd I see you did that in a different PR. The merit badger still needs to get added though (primarily to the main branch)

@mrgrain
Copy link
Contributor

mrgrain commented Nov 15, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Nov 15, 2022

update

✅ Branch has been successfully updated

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 15, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 038aec8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Nov 15, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cbbb42c into aws:v1-main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants