Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-gateway): make request validator construct ids configurable #22900

Closed
wants to merge 1 commit into from
Closed

fix(api-gateway): make request validator construct ids configurable #22900

wants to merge 1 commit into from

Conversation

gkkachi
Copy link
Contributor

@gkkachi gkkachi commented Nov 13, 2022 •
edited
Loading

Fixes #7613

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 13, 2022 14:48
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Nov 13, 2022
@gitpod-io
Copy link

gitpod-io bot commented Nov 13, 2022

@gkkachi gkkachi marked this pull request as draft November 13, 2022 14:57
aws-cdk-automation
aws-cdk-automation requested changes Nov 13, 2022
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

@mergify mergify bot mentioned this pull request Nov 13, 2022
Closed
4 tasks
@gkkachi gkkachi closed this Nov 13, 2022
@gkkachi gkkachi deleted the fix/7613 branch November 13, 2022 15:57
@mergify
Copy link
Contributor

mergify bot commented Nov 13, 2022

⚠️ The sha of the head commit of this PR conflicts with #22901. Mergify cannot evaluate rules on this PR. ⚠️

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Nov 13, 2022

⚠️ The sha of the head commit of this PR conflicts with #22901. Mergify cannot evaluate rules on this PR. ⚠️

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ad2345d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation Awaiting requested review from aws-cdk-automation

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot call request validator options multiple times.
2 participants
@gkkachi @aws-cdk-automation