Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3): use Bucket Policy for Server Access Logging grant (under feature flag) #23386

Merged
merged 3 commits into from
Dec 28, 2022

Commits on Dec 18, 2022

  1. feat(s3): use Bucket Policy for Server Access Logging grant (under fe…

    …ature flag)
    
    Using ACLs to grant access to buckets is no longer recommended. In fact,
    it doesn't work if Object Ownership is set to be enforced for the
    bucket. According to the service documentation for [enabling server
    access logging][1], it is now preferred to use a bucket policy to grant
    permission to deliver logs to a bucket.
    
    Changing the default would result in changes to deployed resources, so
    the new behavior is added behind a feature flag.
    
    [1]: https://docs.aws.amazon.com/AmazonS3/latest/userguide/enable-server-access-logging.html
    laurelmay committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    953c30e View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2022

  1. Configuration menu
    Copy the full SHA
    1023700 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cdcb49a View commit details
    Browse the repository at this point in the history