-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-custom-resource): switch off installLatestAwsSdk
by default
#23591
Merged
Commits on Jan 6, 2023
-
fix(aws-custom-resource): switch off
installLatestAwsSdk
by defaultThe `AwsCustomResource` reaches out to the internet to install the latest AWS SDK by default. This will make it fail if it is being bound to a VPC that doesn't have internet connectivity, or in regions/partitions that are not able to freely connect to `npmjs.com`. This was a poorly chosen default from the time we didn't know any better, but we do know right now. Switch the behavior off by default (under feature flag), and explicitly disable it for all `AwsCustomResource`s the L2 library uses. Lambda advertises 2.1055.0 of the SDK everywhere, and I checked to make sure that all APIs we use are part of that SDK version, so we don't need any newer version. That version is a year old (!) so this is not the end of the story, but it's at least an improvement over what we currently have. Fixes #23113.
Configuration menu - View commit details
-
Copy full SHA for b56ef31 - Browse repository at this point
Copy the full SHA b56ef31View commit details
Commits on Jan 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d0501cb - Browse repository at this point
Copy the full SHA d0501cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 95c71d2 - Browse repository at this point
Copy the full SHA 95c71d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4f06a2 - Browse repository at this point
Copy the full SHA a4f06a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for b254061 - Browse repository at this point
Copy the full SHA b254061View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3507d49 - Browse repository at this point
Copy the full SHA 3507d49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07b4f04 - Browse repository at this point
Copy the full SHA 07b4f04View commit details
Commits on Jan 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2617b5d - Browse repository at this point
Copy the full SHA 2617b5dView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb3e6dc - Browse repository at this point
Copy the full SHA eb3e6dcView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.