Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-custom-resource): switch off installLatestAwsSdk by default #23591

Merged
merged 9 commits into from
Jan 10, 2023

Commits on Jan 6, 2023

  1. fix(aws-custom-resource): switch off installLatestAwsSdk by default

    The `AwsCustomResource` reaches out to the internet to install the
    latest AWS SDK by default. This will make it fail if it is being bound
    to a VPC that doesn't have internet connectivity, or in
    regions/partitions that are not able to freely connect to `npmjs.com`.
    
    This was a poorly chosen default from the time we didn't know any
    better, but we do know right now. Switch the behavior off by default
    (under feature flag), and explicitly disable it for all
    `AwsCustomResource`s the L2 library uses. Lambda advertises 2.1055.0
    of the SDK everywhere, and I checked to make sure that all APIs we
    use are part of that SDK version, so we don't need any newer version.
    
    That version is a year old (!) so this is not the end of the story,
    but it's at least an improvement over what we currently have.
    
    Fixes #23113.
    rix0rrr committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    b56ef31 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. snapshots

    rix0rrr committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    d0501cb View commit details
    Browse the repository at this point in the history
  2. Missing files

    rix0rrr committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    95c71d2 View commit details
    Browse the repository at this point in the history
  3. Snapshots

    rix0rrr committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    a4f06a2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b254061 View commit details
    Browse the repository at this point in the history
  5. Blieptuut

    rix0rrr committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    3507d49 View commit details
    Browse the repository at this point in the history
  6. Boop

    rix0rrr committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    07b4f04 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Update unit test

    rix0rrr committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    2617b5d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    eb3e6dc View commit details
    Browse the repository at this point in the history