Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(iam): correct spelling in documentation #23961

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

kavichu
Copy link
Contributor

@kavichu kavichu commented Feb 1, 2023

chore(iam): correct spelling in documentation


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Fix typo in docs
@gitpod-io
Copy link

gitpod-io bot commented Feb 1, 2023

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Feb 1, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team February 1, 2023 20:25
@github-actions github-actions bot added the p2 label Feb 1, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@kavichu kavichu changed the title Fix typo in documentation docs: correct spelling in documentation Feb 1, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 1, 2023 20:47

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mrgrain mrgrain changed the title docs: correct spelling in documentation chore(iam): correct spelling in documentation Feb 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review February 2, 2023 14:50

Pull request has been modified.

@mrgrain
Copy link
Contributor

mrgrain commented Feb 2, 2023

@kavichu Thanks for the fix and updating the branch!

In this case it was needed. But just for future reference: Normally you should not update the branch from main, unless there are merge conflicts or workflow conflicts (like this time). It makes everything more complicated for us since any previous reviews will be revoked etc.

@kavichu
Copy link
Contributor Author

kavichu commented Feb 2, 2023

@kavichu Thanks for the fix and updating the branch!

In this case it was needed. But just for future reference: Normally you should not update the branch from main, unless there are merge conflicts. It just makes everything more complicated for us since any previous reviews will be revoked etc.

@mrgrain Sorry for that, I am really into learning the workflow. I thought it would update my fork branch and then hit back to this PR, thanks for the explanation.

@mrgrain
Copy link
Contributor

mrgrain commented Feb 2, 2023

@kavichu Thanks for the fix and updating the branch!
In this case it was needed. But just for future reference: Normally you should not update the branch from main, unless there are merge conflicts. It just makes everything more complicated for us since any previous reviews will be revoked etc.

@mrgrain Sorry for that, I am really into learning the workflow. I thought it would update my fork branch and then hit back to this PR, thanks for the explanation.

All good! In this situation we did hit one of the two scenarios where an update is required.

It's more of an FYI. Unfortunately GitHub has this shiny "Update branch" button that we cannot disable. 😅
If you ever want to update for any other reason, you can comment @mergifyio update and the automation will take over.

@kavichu
Copy link
Contributor Author

kavichu commented Feb 2, 2023

@kavichu Thanks for the fix and updating the branch!
In this case it was needed. But just for future reference: Normally you should not update the branch from main, unless there are merge conflicts. It just makes everything more complicated for us since any previous reviews will be revoked etc.

@mrgrain Sorry for that, I am really into learning the workflow. I thought it would update my fork branch and then hit back to this PR, thanks for the explanation.

All good! In this situation we did hit one of the two scenarios where an update is required.

It's more of an FYI. Unfortunately GitHub has this shiny "Update branch" button that we cannot disable. 😅 If you ever want to update for any other reason, you can comment @mergifyio update and the automation will take over.

Awesome, next time I know about @mergifyio update and that the shiny button is there only trick you into click it and see what happens. Deep inside I wanted to know what will happen.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 68e630b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 29cf3c0 into aws:main Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants