-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(iam): correct spelling in documentation #23961
Conversation
Fix typo in docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
@kavichu Thanks for the fix and updating the branch! In this case it was needed. But just for future reference: Normally you should not update the branch from main, unless there are merge conflicts or workflow conflicts (like this time). It makes everything more complicated for us since any previous reviews will be revoked etc. |
@mrgrain Sorry for that, I am really into learning the workflow. I thought it would update my fork branch and then hit back to this PR, thanks for the explanation. |
All good! In this situation we did hit one of the two scenarios where an update is required. It's more of an FYI. Unfortunately GitHub has this shiny "Update branch" button that we cannot disable. 😅 |
Awesome, next time I know about |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
chore(iam): correct spelling in documentation
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license