Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipelines): cannot configure actionName for all sources #24027

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 6, 2023

Add the ability for GitHub, CodeStar Connections, CodeCommit source types to configure the Action Name that is added to the pipeline.

This is necessary to add the same GitHub repository to the same pipeline twice with a different branch each time. By default, it would pick the same default name for each, which would then conflict.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Add the ability for GitHub, CodeStar Connections, ECR source types
to configure the Action Name that is added to the pipeline.

This is necessary to add the same GitHub repository to the same pipeline
twice with a different branch each time. By default, it would pick the
same default name for each, which would then conflict.
@rix0rrr rix0rrr requested a review from a team February 6, 2023 09:58
@rix0rrr rix0rrr self-assigned this Feb 6, 2023
@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Feb 6, 2023
@gitpod-io
Copy link

gitpod-io bot commented Feb 6, 2023

@github-actions github-actions bot added the p2 label Feb 6, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team February 6, 2023 09:58
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 443abc7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9cd639b into main Feb 6, 2023
@mergify mergify bot deleted the huijbers/action-name branch February 6, 2023 21:05
@mergify
Copy link
Contributor

mergify bot commented Feb 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants