Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(region-info): Init Spain and Zurich #24122

Closed
wants to merge 2 commits into from
Closed

chore(region-info): Init Spain and Zurich #24122

wants to merge 2 commits into from

Conversation

watany-dev
Copy link
Contributor

@watany-dev watany-dev commented Feb 12, 2023 •
edited
Loading

fixes #23619

Note:
At first I intended to target only Spain; setting CLOUDWATCH_LAMBDA_INSIGHTS_ARNS 1.0.178.0 revealed that I needed Zurich. We did this as well.

@aws-cdk-automation aws-cdk-automation requested a review from a team February 12, 2023 01:58
@github-actions github-actions bot added the star-contributor [Pilot] contributed between 25-49 PRs to the CDK label Feb 12, 2023
@gitpod-io
Copy link

gitpod-io bot commented Feb 12, 2023

@github-actions github-actions bot added the p2 label Feb 12, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f72a1d8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 and removed p2 labels Feb 12, 2023
@kaizencc
Copy link
Contributor

Hi @watany-dev, I'm going to close this one because a few PRs have beat you to it:

They're still open, because there's a bit of a dependency thing happening, but I'm going to give preference to what came first.

@kaizencc kaizencc closed this Feb 12, 2023
@watany-dev
Copy link
Contributor Author

@kaizencc

That is unfortunate. To break these dependencies, it would be a good idea to do a region init without the layer first!

@kaizencc
Copy link
Contributor

@watany-dev what do you mean? Not sure how we are breaking dependencies?

@watany-dev
Copy link
Contributor Author

watany-dev commented Feb 14, 2023 •
edited
Loading

@kaizencc
No, sorry, I read the three PRs again and it seems my understanding was mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Register new region: eu-south-2
3 participants
@watany-dev @aws-cdk-automation @kaizencc