chore: add TimeZones class #24127
chore: add TimeZones class #24127
Conversation
This adds the time zones in the 2022g release of the Time Zone Database. It has been tested in the context of the tests written in #23123, but I didn't commit them here because I didn't want to overwrite that change.
|
|
There was a problem hiding this comment.
This is great, long needed in the CDK 🚀
Did you consider ways to automate the generation and updating process?
The IANA database is updated fairly regularly (couple times a year) and I can see going through a long list being very painful.
Related, do we know yet how we want to handle deprecated/removed timezones (if there even is such a thing)?
No automation yet, but you're right that we do need it. Deprecated and removed timezones get mapped to a new one so we can remap them when that happens. We should also figure out how to automate this. |
TheRealAmazonKendra
removed
the
pr/do-not-merge
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This adds the time zones in the 2022g release of the Time Zone Database.
It has been tested in the context of the tests written in #23123, but I didn't commit them here because I didn't want to overwrite that change.
I couldn't decide whether this should be a chore or a feat. I'm open to either.
Closes #.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license