fix(ecs): memory issue in validateTaskDefinition()

[jackhannan-hello]

If you where to add a container definition to a fargate task definition if you where to include memory or memoryResorvation which at least one is required you get an error. I added a first if statement to see if the parent container has memory and then see if the other containers have memory .

`private validateTaskDefinition(): string[] {
const ret = new Array();

if (isEc2Compatible(this.compatibility)) {
  // EC2 mode validations

  // Container sizes
  for (const container of this.containers) {
    if (container.memoryLimitSpecified && container === this.containers[0]) {
      break;
    } else if (!container.memoryLimitSpecified) {
      ret.push(`ECS Container ${container.containerName} must have at least one of 'memoryLimitMiB' or 'memoryReservationMiB' specified`);
    }
  }

}`

https://github.com/jackhannan-hello/aws-cdk/blob/8598a44350a932ddc7e05f99b089e35e4c4a9fcf/packages/aws-cdk-lib/aws-ecs/lib/base/task-definition.ts#L735-L750

I did this so that if the parent has a specified memory it will exit the loop checking for memory so that if one of your sub containers has no memory specified it does not throw an error. If there is no specified memory in the parent it will go through all of the sub containers to make sure it has memory specified.

Closes #25275.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 8598a44
• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[peterwoodworth]

Hey @jackhannan-hello, thanks for submitting this

You've commited a fresh package-lock.json to the root, did you use yarn install --frozen-lockfile to install your packages? There shouldn't be a fresh package.json here

Additionally, you've added two dependencies that don't seem to get used

import { measureMemory } from 'node:vm';
import { aws_memorydb } from '../../..';

I don't think we need these, and they can be removed.

Regarding testing, could you please add a unit test which checks that this synthesizes correctly when correctly used, and another unit test which throws when misconfigured? Additionally, be sure to run the integ test you've created with our integ-runner CLI. The contributing guide should shed some light on this 🙂

[aws-cdk-automation]

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.