Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk-lib): Pass lookupRoleArn to NestedStackSynthesizer #25625

Closed
wants to merge 1 commit into from

Conversation

IgnacioAcunaF
Copy link
Contributor

@IgnacioAcunaF IgnacioAcunaF commented May 17, 2023

NestedStack's synthesizer doesn't receive the lookupRoleArn from the parent stack synthesizer, so the NestedStack tries with local credentials (of the deployment account) instead of assuming a cross-account role (on the target account) as regular non-nested Stack would do.

This PR aims to add lookupRoleArn reference to the StackSynthesizer class and IStackSynthesizer, so it can be use on the NestedStack to explicitly set an IAM role in case of parent stack having one already defined, so CDK uses the role instead of local credentials.

Closes #25171.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 17, 2023

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label May 17, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 17, 2023 07:35
@github-actions github-actions bot added bug This issue is a bug. p2 labels May 17, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@IgnacioAcunaF IgnacioAcunaF changed the title Pass lookupRoleArn to NestedStackSynthesizerfrom parent Stack fix(aws-cdk-lint): Pass lookupRoleArn to NestedStackSynthesizerfrom parent Stack May 17, 2023
@IgnacioAcunaF IgnacioAcunaF changed the title fix(aws-cdk-lint): Pass lookupRoleArn to NestedStackSynthesizerfrom parent Stack fix(aws-cdk-lint): Pass lookupRoleArn to NestedStackSynthesizer May 17, 2023
@IgnacioAcunaF IgnacioAcunaF changed the title fix(aws-cdk-lint): Pass lookupRoleArn to NestedStackSynthesizer fix(cdk-lib): Pass lookupRoleArn to NestedStackSynthesizer May 17, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 682bb86
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@peterwoodworth peterwoodworth added p1 and removed p2 labels May 17, 2023
@github-actions github-actions bot added effort/medium Medium work item – several days of effort and removed p2 labels May 17, 2023
@peterwoodworth
Copy link
Contributor

@IgnacioAcunaF can you please either add tests, or make a request? We won't be able to provide a meaningful review otherwise

@IgnacioAcunaF
Copy link
Contributor Author

@peterwoodworth sure, will work on that!

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Jun 16, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to a test file.
❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/medium Medium work item – several days of effort p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pipelines: Cannot perform lookup in cross-account nested stack
3 participants