Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backup): validation for vault name fails when parameters are referred in the name #25943

Merged
merged 6 commits into from
Aug 18, 2023

Conversation

tam0ri
Copy link
Contributor

@tam0ri tam0ri commented Jun 12, 2023

Validation for Backup vault name fails when parameters are referred in the name now. Current implementation simply validates vault name with regular expression described in CFn reference, so it does not consider the special characters for parameters. This PR solves the issue by checking props.backupVaultName is resolved.

Closes #21735


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 12, 2023

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. labels Jun 12, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 12, 2023 15:37
@github-actions github-actions bot added effort/small Small work item – less than a day of effort p2 labels Jun 12, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@tam0ri tam0ri changed the title fix(aws-backup): validation for vault name fails when parameters are referred in the name fix(backup): validation for vault name fails when parameters are referred in the name Jun 12, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 12, 2023 15:41

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 17, 2023
corymhall
corymhall previously approved these changes Jun 29, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed corymhall’s stale review June 30, 2023 12:02

Pull request has been modified.

@tam0ri tam0ri requested a review from corymhall July 18, 2023 13:09
Copy link
Contributor

@jumic jumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jul 28, 2023
Comment on lines 49 to 51
recoveryPointTags: {
stage: 'prod',
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removed from the existing integ test?

Copy link
Contributor Author

@tam0ri tam0ri Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember the intention at the time, but it might be by my mistake. These lines were introduced few days before I submitted this PR, so I guess that I took some miss operation in my local environment at the time. Anyway, thank you for your nice catching! I'll revert this change and regenerate snapshots.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jul 28, 2023
@tam0ri tam0ri requested a review from jogold August 8, 2023 08:03
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d111a40
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 00a7f03 into aws:main Aug 18, 2023
8 checks passed
@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-backup: Attribute BackupVault.props.backupVaultName fails a validation when used with parameters
6 participants